Skip to content
This repository has been archived by the owner on Jan 15, 2024. It is now read-only.

Remove gluonnlp.layers.HybridSequential #1427

Merged
merged 2 commits into from
Nov 5, 2020
Merged

Conversation

leezu
Copy link
Contributor

@leezu leezu commented Nov 5, 2020

As title. No longer needed as of apache/mxnet@3d1df4e

@leezu leezu requested a review from a team as a code owner November 5, 2020 05:01
@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #1427 into master will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1427      +/-   ##
==========================================
+ Coverage   85.27%   85.33%   +0.06%     
==========================================
  Files          53       53              
  Lines        6960     6928      -32     
==========================================
- Hits         5935     5912      -23     
+ Misses       1025     1016       -9     
Impacted Files Coverage Δ
src/gluonnlp/layers.py 87.15% <100.00%> (+1.68%) ⬆️
src/gluonnlp/models/albert.py 95.43% <100.00%> (-0.02%) ⬇️
src/gluonnlp/models/bert.py 94.80% <100.00%> (ø)
src/gluonnlp/models/electra.py 76.83% <100.00%> (ø)
src/gluonnlp/models/gpt2.py 98.25% <100.00%> (ø)
src/gluonnlp/models/mobilebert.py 87.82% <100.00%> (ø)
src/gluonnlp/models/roberta.py 93.61% <100.00%> (ø)
src/gluonnlp/models/transformer.py 98.94% <100.00%> (ø)
src/gluonnlp/models/transformer_xl.py 82.44% <100.00%> (ø)
src/gluonnlp/data/tokenizers/yttm.py 81.89% <0.00%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2032159...18ac22c. Read the comment docs.

Copy link
Member

@sxjscience sxjscience left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We may fix the doc error later.

@szha szha merged commit f3d209f into dmlc:master Nov 5, 2020
@leezu leezu deleted the mx2hybridsequential branch November 5, 2020 16:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants